Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
libtorch is available as python3Packages.pytorch.{out,dev}. However, I
think there are several good reasons for also providing upstream's
prebuilt libtorch:
one of my own natural language processing tools and this resulted in
50% faster CPU inference. We support building with MKL in our
PyTorch derivation, but that incurs a large build time.
support CUDA in our derivation, but it requires an expensive PyTorch
build.
derivation is temporarily broken, which is typically only found out
somewhere during the build.
Since the same libraries are distributed through PyPi, I would assume
that redistribution is fine. But I can ask upstream if necessary.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)