Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtorch-bin: init at 1.6.0 #96488

Merged
merged 1 commit into from Sep 1, 2020
Merged

libtorch-bin: init at 1.6.0 #96488

merged 1 commit into from Sep 1, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Aug 27, 2020

Motivation for this change

libtorch is available as python3Packages.pytorch.{out,dev}. However, I
think there are several good reasons for also providing upstream's
prebuilt libtorch:

  • Upstream has a license to distribute PyTorch with MKL. I benchmarked
    one of my own natural language processing tools and this resulted in
    50% faster CPU inference. We support building with MKL in our
    PyTorch derivation, but that incurs a large build time.
  • Upstream also has a license to distribute CUDA with MKL. Again, we
    support CUDA in our derivation, but it requires an expensive PyTorch
    build.
  • No build time. This is nice for downstream users when the PyTorch
    derivation is temporarily broken, which is typically only found out
    somewhere during the build.
  • Possibly breaks less often than builds of the PyTorch derivation.

Since the same libraries are distributed through PyPi, I would assume
that redistribution is fine. But I can ask upstream if necessary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
Copy link
Contributor Author

Opened a topic upstream to ask about redistribution:

https://discuss.pytorch.org/t/redistributing-pytorch/94339

@danieldk
Copy link
Contributor Author

Since the same libraries are distributed through PyPi, I would assume
that redistribution is fine. But I can ask upstream if necessary.

Changed the license to unfree for now, builds are so fast anyway that having this in the binary cache is not really needed.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/improving-nixos-data-science-infrastructure-ci-for-mkl-cuda/5074/44

@danieldk danieldk merged commit 53880bd into NixOS:master Sep 1, 2020
@danieldk danieldk deleted the libtorch branch September 1, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants