Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patchelf: 0.11 -> 0.12 #96513

Merged
merged 2 commits into from Aug 28, 2020
Merged

patchelf: 0.11 -> 0.12 #96513

merged 2 commits into from Aug 28, 2020

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Aug 28, 2020

Motivation for this change
  • Fixes handling of PT_NOTE section, which broke Mesa (and has reportedly broken other things according to patchelf users, we might just not have noticed it or been lucky).
  • Fixes handling of section alignment of ARMv8.

cc @domenkozar -- I see last time for the 0.9 -> 0.11 bump you used a special branch and probably a special Hydra jobset. Given that the 0.11 -> 0.12 delta is smaller, do you think we should go through that or is staging enough?

This PR also includes a cleanup to make Mesa use the default patchelf again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from vcunat, primeos and edolstra August 28, 2020 03:23
vcunat
vcunat approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

I expect it can go directly to staging. It's OK that this won't make it to 20.09, right?

@edolstra edolstra merged commit 424fd11 into NixOS:staging Aug 28, 2020
@primeos primeos mentioned this pull request Sep 8, 2020
Closed
@vcunat
Copy link
Member

vcunat commented Sep 8, 2020

But it caused a regression: #97407

@jtojnar jtojnar mentioned this pull request Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@primeos primeos Awaiting requested review from primeos

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @vcunat @edolstra