python3.pkgs.pyexcel: init at 0.6.4 #96483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Aug 29, 2020
There was a problem hiding this comment.
for packages that can't run tests, do you mind adding pythonImportsCheck?
If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see pythonImportsCheck documentation for more information.
|
Done, thanks. |
jonringer
approved these changes
Aug 29, 2020
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 96483 1
13 packages built:
- python27Packages.lml
- python27Packages.pyexcel-io
- python27Packages.pyexcel-xls
- python37Packages.lml
- python37Packages.pyexcel
- python37Packages.pyexcel-io
- python37Packages.pyexcel-ods
- python37Packages.pyexcel-xls
- python38Packages.lml
- python38Packages.pyexcel
- python38Packages.pyexcel-io
- python38Packages.pyexcel-ods
- python38Packages.pyexcel-xls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Just needed this again so I finally packaged it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"nix-shell -I nixpkgs=$HOME/Projects/nixpkgs -p 'python3.withPackages(ps: with ps; [ pyexcel pyexcel-ods ])' --run 'python3 -c "import pyexcel; print(pyexcel.get_records(file_name=\"data.ods\", sheet_name=\"INFO\"))"'nix path-info -Sbefore and after)