Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kigo: fix meta #96527

Merged
merged 1 commit into from Aug 28, 2020
Merged

kigo: fix meta #96527

merged 1 commit into from Aug 28, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Aug 28, 2020 •
edited

Motivation for this change

Fixing a homepage url and a French description
#93840 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk suggested changes Aug 28, 2020
View reviewed changes
pkgs/applications/kde/kigo.nix Outdated Show resolved Hide resolved
danieldk
danieldk approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@danieldk danieldk merged commit b3faa9f into NixOS:staging Aug 28, 2020
@danieldk
Copy link
Contributor

By the way, this could have gone to master, instead of staging. Noticed too late. No harm done I guess ;).

@freezeboy freezeboy deleted the fix-kigo-meta branch August 28, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @danieldk