Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dlang toolchain update #99392

Closed
wants to merge 1 commit into from
Closed

Dlang toolchain update #99392

wants to merge 1 commit into from

Conversation

dukc
Copy link
Contributor

@dukc dukc commented Oct 2, 2020 •
edited

Motivation for this change

Routine update of D compiler and DUB package manager versions, so the newest D code keeps compiling

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Binary ldc-build-runtime does not work, and neither does generating a profile for profile-guided-optimization (so I cannot test ldc-profdata except for it's error messages). But both of these issues exist regardless of this PR.

@dukc
dmd: 2.091.1 -> 2.094.0
02f0dbe 
ldc: 1.20.1 -> 1.23.0
dub: 1.14.0 -> 1.23.0
@dukc
Copy link
Contributor Author

dukc commented Oct 2, 2020

cc @lionello @ThomasMader

@ofborg ofborg bot requested a review from lionello October 2, 2020 18:18
@dukc
Copy link
Contributor Author

dukc commented Oct 16, 2020

cc @lionello @ThomasMader

@ajs124
Copy link
Member

ajs124 commented Oct 16, 2020

This seems to break the build of tilix, whatever that is.

@lionello
Copy link
Contributor

I got the following error while trying to build ldc on Darwin (10.15.7):

llvm-config: unknown component name: windowsmanifest
CMake Error at cmake/Modules/FindLLVM.cmake:49 (message):
  Failed to execute llvm-config
  ('/nix/store/6mrlff722irhci2psf59h2jbcrlm2fry-llvm-5.0.2/bin/llvm-config',
  result code: '1)'
Call Stack (most recent call first):
  cmake/Modules/FindLLVM.cmake:96 (_LLVM_FAIL)
  cmake/Modules/FindLLVM.cmake:121 (llvm_set_libs)
  CMakeLists.txt:34 (find_package)

@dukc
Copy link
Contributor Author

dukc commented Oct 20, 2020

Tilix is a terminal emulator that is written in D, that's why. I'm investigating, it seems that it's failing to link to a few Druntime library template instances.

But I don't have a Mac so investigating the Darwin problem is easier said than done. I have no experience about Darling, does it pay to try to troubleshoot Darwin builds with it?

@lionello
Copy link
Contributor

lionello commented Nov 6, 2020

This worked: #102964 (comment)

@fabianhjr
Copy link
Member

Hi @dukc, an update of ldc to 1.24.0 was merged recently on #102964 which seemed to be tho only blocker for an upgrade of dmd.

@dukc
Copy link
Contributor Author

dukc commented Nov 9, 2020

Hi @dukc, an update of ldc to 1.24.0 was merged recently on #102964 which seemed to be tho only blocker for an upgrade of dmd.

Okay so I quess I don't have to update LDC anymore. I still should update DMD and DUB though, plus get Tilix to link DRuntime again.

SuperSandro2000
SuperSandro2000 requested changes Nov 24, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the three updates in three separate commits and also fix the merge conflict.

@dukc dukc mentioned this pull request Nov 28, 2020
Merged
10 tasks
@dukc
Copy link
Contributor Author

dukc commented Nov 28, 2020

Please put the three updates in three separate commits and also fix the merge conflict.

LDC is already updated, so no need for that
As for DMD, the Tilix failure is cryptic enough that I lost motivation trying to hunt for it. I'll just skip updating DMD at least for now.
But I can still update DUB. Reboot here: #105269

@dukc dukc closed this Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@lionello lionello Awaiting requested review from lionello

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dukc @ajs124 @lionello @fabianhjr @SuperSandro2000 @Janik-Haag