Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profile update in nix command #4101

Merged
merged 1 commit into from Oct 2, 2020
Merged

Fix profile update in nix command #4101

merged 1 commit into from Oct 2, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Oct 2, 2020

This fixes a wrong assertion when using nix --profile ... to update a profile:

$ nix build --profile my-profile -v nix
nix: src/nix/command.cc:155: nix::MixProfile::updateProfile(const Buildables&)::<lambda(nix::BuildableFromDrv)>: Assertion `!output.second' failed.
[1]    9634 abort (core dumped)  nix build --profile my-profile -v nix

This typo was intorduced by e9fad30.

CC @Ericson2314

@grahamc
Copy link
Member

grahamc commented Oct 2, 2020

It would be really nice to have some (unit and/or integration) tests on stuff like this. :(

@edolstra edolstra merged commit 57b935a into NixOS:master Oct 2, 2020
@B4dM4n B4dM4n deleted the fix-profile-update branch October 2, 2020 13:26
@ldesgoui ldesgoui mentioned this pull request Aug 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@B4dM4n @grahamc @edolstra