Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomachine-client: 6.11.2 -> 6.12.3 #99395

Merged
merged 1 commit into from Oct 15, 2020
Merged

nomachine-client: 6.11.2 -> 6.12.3 #99395

merged 1 commit into from Oct 15, 2020

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Oct 2, 2020

Motivation for this change

Update nomachine-client to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz talyz added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 2, 2020
@austinbutler austinbutler mentioned this pull request Oct 14, 2020
Closed
austinbutler
austinbutler approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@austinbutler austinbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me in an overlay, nixpkgs-review pr 99395 builds successfully as well.

@talyz talyz linked an issue Oct 15, 2020 that may be closed by this pull request
package nomachine-client cannot build #100377
Closed
@talyz talyz merged commit a5aebef into NixOS:master Oct 15, 2020
This was referenced Oct 15, 2020
Merged
Merged
@talyz talyz deleted the nomachine-6.12.3 branch October 21, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinbutler austinbutler austinbutler approved these changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package nomachine-client cannot build
2 participants
@talyz @austinbutler