Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

volctl: 0.6.3 -> 0.8.0 #99410

Closed
wants to merge 2 commits into from
Closed

volctl: 0.6.3 -> 0.8.0 #99410

wants to merge 2 commits into from

Conversation

pinpox
Copy link
Member

@pinpox pinpox commented Oct 2, 2020

Motivation for this change

Update to version 0.8.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [x ] Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pinpox pinpox changed the title Update volctl package volctl: 0.6.3 -> 0.8.0 Oct 2, 2020
@ofborg ofborg bot requested a review from romildo October 2, 2020 23:58
etu
etu requested changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@etu etu left a comment •
edited by romildo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even after fixing the download I get build errors about missing dependencies:

ERROR: Could not find a version that satisfies the requirement PyYAML (from volctl==0.8.0) (from versions: none)
ERROR: No matching distribution found for PyYAML (from volctl==0.8.0)

The commit message should also be formatted volctl: 0.6.3 -> 0.8.0 on the first line of the message, not just the pull request. Amending the commit should solve that for you.

Also, thank you for the pull request, just need to fix a couple of things and it should all be fine :)

pkgs/tools/audio/volctl/default.nix Outdated Show resolved Hide resolved
@pinpox @etu
Update pkgs/tools/audio/volctl/default.nix
d3d6a67 
Co-authored-by: Elis Hirwing <elis@hirwing.se>
@romildo
Copy link
Contributor

romildo commented Oct 3, 2020

The following python modules (new dependencies) should be added to the python path:

  • click
  • pycairo
  • pyyaml

Also explicitly use python3Packages, as it is not compatible with Pyton 2 anymore.

@pinpox
Copy link
Member Author

pinpox commented Oct 3, 2020

Also explicitly use python3Packages, as it is not compatible with Pyton 2 anymore.

Sorry, I don't know how to do that, this is my first nix package contribution

@romildo
Copy link
Contributor

romildo commented Oct 3, 2020

Also explicitly use python3Packages, as it is not compatible with Pyton 2 anymore.

Sorry, I don't know how to do that, this is my first nix package contribution

Just replace pythonPackages with python3Packages.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 28, 2020
Merged
10 tasks
@SuperSandro2000
Copy link
Member

Replaced by #99410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu requested changes

@romildo romildo Awaiting requested review from romildo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pinpox @romildo @SuperSandro2000 @etu @Janik-Haag