Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebar3: 3.12.0 -> 3.14.2 #99372

Merged
merged 1 commit into from Nov 21, 2020
Merged

rebar3: 3.12.0 -> 3.14.2 #99372

merged 1 commit into from Nov 21, 2020

Conversation

cw789
Copy link
Contributor

@cw789 cw789 commented Oct 2, 2020

Motivation for this change

Keeping things up-to-date?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cw789
Copy link
Contributor Author

cw789 commented Oct 2, 2020

Test via nixpkgs-review pr 99372 does fail!!!
Edit: Concerned rebar3 v3.14.1

builder for '/nix/store/8iplq7ld9b9vxzjqgd0y9jcz51gqyy2f-rebar3-3.14.1.drv' failed with exit code 1; last 10 log lines:
  patching sources
  configuring
  no configure script, doing nothing
  building
  Error: Unable to fetch package providers 1.8.1: failed connect
  Error: Unable to fetch package getopt 1.0.1: failed connect
  Error: Unable to fetch package cf 0.3.1: failed connect
  Error: Unable to fetch package erlware_commons 1.3.1: failed connect
  /build/source/_build/default/lib/erlware_commons/src/ec_dictionary.erl:none: no such file or directory

cannot build derivation '/nix/store/xws4l7fwz72ph7wmnwl3ahjlm7wn805k-relx-exe-3.32.1.drv': 1 dependencies couldn't be built
builder for '/nix/store/1vxi9fzaf6fggm727r4pla8xn77qkkq3-rebar3-3.14.1.drv' failed with exit code 1; last 10 log lines:
  patching sources
  configuring
  no configure script, doing nothing
  building
  Error: Unable to fetch package providers 1.8.1: failed connect
  Error: Unable to fetch package getopt 1.0.1: failed connect
  Error: Unable to fetch package cf 0.3.1: failed connect
  Error: Unable to fetch package erlware_commons 1.3.1: failed connect
  /build/source/_build/default/lib/erlware_commons/src/ec_dictionary.erl:none: no such file or directory

So I'm probably the wrong person to update rebar3.
As I've already mentioned to not understanding what's going on in this builder.
discourse.nixos.org

So please close, if this PR is worthless...

@berbiche
Copy link
Member

Version 3.14.2 has been released

@cw789 cw789 changed the title rebar3: 3.12.0 -> 3.14.1 rebar3: 3.12.0 -> 3.14.2 Nov 20, 2020
@cw789
Copy link
Contributor Author

cw789 commented Nov 20, 2020

Tested now (3.14.2) via nixpkgs-review pr 99372

3 packages built:
lfe rebar3 relxExe

rebar3 --version

rebar 3.14.2 on Erlang/OTP 22 Erts 10.7

So on my side, I think this is ready to merge.
Thanks @berbiche.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/376

@AndersonTorres AndersonTorres merged commit f1fd8f3 into NixOS:master Nov 21, 2020
@cw789 cw789 deleted the rebar3_update branch September 10, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants