New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
knightos-mktiupgrade: init at 1.1.6 #99374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siraben
force-pushed
the
mktiupgrade-init
branch
from
October 10, 2020 08:21
cbf11c8
to
b982552
Compare
siraben
force-pushed
the
mktiupgrade-init
branch
from
October 10, 2020 08:27
e8ddd44
to
56c910d
Compare
siraben
changed the title
knightos-mktiupgrade: init at unstable-2020-01-28
knightos-mktiupgrade: init at 1.1.6
Oct 10, 2020
danieldk
suggested changes
Oct 14, 2020
danieldk
reviewed
Oct 14, 2020
siraben
force-pushed
the
mktiupgrade-init
branch
from
October 15, 2020 04:30
1c5b378
to
2b3564d
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
labels
Oct 15, 2020
danieldk
force-pushed
the
mktiupgrade-init
branch
from
October 16, 2020 04:50
2b3564d
to
964d192
Compare
Need to update description, looks like it's the one for |
siraben
force-pushed
the
mktiupgrade-init
branch
from
October 16, 2020 05:05
964d192
to
a617f19
Compare
danieldk
force-pushed
the
mktiupgrade-init
branch
from
October 16, 2020 05:48
a617f19
to
f8ca1be
Compare
I have pushed an update to remove arguments that are now unneeded ( |
danieldk
approved these changes
Oct 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add knightos-mktiupgrade
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)