treewide: fix redirected urls #99369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: - 9fc5e7e - 593e11f - 508ae42 Since the last time I ran this script, the Repology API changed, so I had to adapt the script used in the previous PR. The new API should be more robust, so overall this is a positive (no more grepping the error messages for our relevant data but just a nice json structure). Here's the new script I used: ```sh curl https://repology.org/api/v1/repository/nix_unstable/problems \ | jq -r '.[] | select(.type == "homepage_permanent_https_redirect") | .data | "s@\(.url)@\(.target)@"' \ | sort | uniq | tee script.sed find -name '*.nix' | xargs -P4 -- sed -f script.sed -i ``` I will also add this script to `maintainers/scripts`.
…s using Repology data
|
Sorry for the pings code owners :( |
ofborg
bot
added
6.topic: lua
6.topic: python
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
ofborg
bot
added
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-linux: 0
labels
marsam
reviewed
Oct 2, 2020
marsam
approved these changes
Oct 2, 2020
jonringer
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
diff LGTM
nice script :)
was able to run ofborg locally
$ nix-instantiate ./nixos/release.nix --option restrict-eval true -I foo=. --arg nixpkgs '{ outPath = ./.; revCount = 0; shortRev = "aabbcc"; }'
warning: dumping very large path (> 256 MiB); this may run out of memory
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
/nix/store/bzhayi9ljcy432z34lj9hlz1n151i2ax-nixos-channel-21.03pre0.aabbcc.drv
/nix/store/mdca90jpg2d8w6k3if565rp3vrd3wllv-options.json.drv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Related:
Since the last time I ran this script, the Repology API changed, so I had to
adapt the script used in the previous PR. The new API should be more robust, so
overall this is a positive (no more grepping the error messages for our relevant
data but just a nice json structure).
Here's the new script I used:
I also added this script to
maintainers/scripts.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)