Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uudeview: don't hardeningDisable format #99403

Merged
merged 1 commit into from Sep 17, 2021
Merged

uudeview: don't hardeningDisable format #99403

merged 1 commit into from Sep 17, 2021

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Oct 2, 2020

Motivation for this change
  • adopt a patch which several other distributions use
  • name -> pname + version
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99403 run on x86_64-linux 1

1 package built:
  • uudeview

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99403 run on x86_64-linux 1

1 package built:
  • uudeview

infinisil
infinisil requested changes Nov 28, 2020
View reviewed changes
pkgs/tools/misc/uudeview/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 99403 run on x86_64-linux 1

1 package built:
  • uudeview

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

@stale
Copy link

stale bot commented Aug 17, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 17, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 17, 2021
@woffs
uudeview: don't hardeningDisable format
60f8a42 
- adopt a patch which several other distributions use
- name -> pname + version
- license: gpl2Plus
@infinisil infinisil merged commit d46295c into NixOS:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@woffs @SuperSandro2000 @infinisil