Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trivy: init at 0.11.0 #99407

Merged
merged 1 commit into from Oct 13, 2020
Merged

trivy: init at 0.11.0 #99407

merged 1 commit into from Oct 13, 2020

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Oct 2, 2020 •
edited

Motivation for this change

Add the trivy vulnerability scanner to nixpkgs

I categorized it in tools/admin because that's where the clair vulnerability scanner is already.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions (aarch64 archlinux)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit October 2, 2020 23:25
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/316

@06kellyjac 06kellyjac force-pushed the init_trivy branch 2 times, most recently from c527634 to b52b077 Compare October 13, 2020 09:43
AndersonTorres
AndersonTorres suggested changes Oct 13, 2020
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just cosmetic changes. We need beautiful code too :)

pkgs/tools/admin/trivy/default.nix Outdated Show resolved Hide resolved
AndersonTorres
AndersonTorres approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, LGTBorg

@AndersonTorres AndersonTorres merged commit f67893d into NixOS:master Oct 13, 2020
@06kellyjac 06kellyjac deleted the init_trivy branch October 13, 2020 13:41
@06kellyjac
Copy link
Member Author

Thanks for the reviews @AndersonTorres

This was referenced Oct 13, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@06kellyjac @nixos-discourse @AndersonTorres