Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/shiori: harden service with systemd #99408

Merged
merged 1 commit into from Oct 28, 2020

Conversation

minijackson
Copy link
Member

Motivation for this change

It's best when it's hardened

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

@minijackson I wonder if you would be interested in submitting a PR upstream to add a systemd unit so others could benefit.

@bjornfor I'll leave to you to merge this because I'm not familiar with this software.

@bjornfor
Copy link
Contributor

@bjornfor I'll leave to you to merge this because I'm not familiar with this software.

I'm not either :-)

@bjornfor bjornfor merged commit 3fce272 into NixOS:master Oct 28, 2020
@minijackson minijackson deleted the shiori-harden-service branch November 10, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants