Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odpic: 3.3.0 -> 4.0.2 #99385

Merged
merged 1 commit into from Oct 11, 2020
Merged

odpic: 3.3.0 -> 4.0.2 #99385

merged 1 commit into from Oct 11, 2020

Conversation

maxxk
Copy link
Contributor

@maxxk maxxk commented Oct 2, 2020

Motivation for this change

python3Packages.cx-oracle is broken with current odpic version.
Supersedes #91631

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nixpkgs-review:

3 packages failed to build:
python27Packages.cx_oracle python37Packages.patator python38Packages.patator

3 packages built:
odpic python37Packages.cx_oracle python38Packages.cx_oracle

patator is broken in master and release-20.09.
python27Packages.cx_oracle: cx_oracle 8 supports python 3.5+ only.

@maxxk
odpic: 3.3.0 -> 4.0.2
5abf2b4 
python3Packages.cx-oracle is broken with current odpic version
@maxxk
Copy link
Contributor Author

maxxk commented Oct 10, 2020

Asking for a review from maintainers @mulderr @flokli

@mulderr mulderr self-requested a review October 11, 2020 19:18
mulderr
mulderr approved these changes Oct 11, 2020
View reviewed changes
Copy link
Contributor

@mulderr mulderr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I propose we close #91631 in favor of this one.

@flokli flokli merged commit cddb921 into NixOS:master Oct 11, 2020
@maxxk maxxk mentioned this pull request Oct 20, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mulderr mulderr mulderr approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxxk @mulderr @flokli