Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avro-python3: Add missing dependencies #99397

Merged
merged 1 commit into from Oct 6, 2020
Merged

avro-python3: Add missing dependencies #99397

merged 1 commit into from Oct 6, 2020

Conversation

clefru
Copy link
Contributor

@clefru clefru commented Oct 2, 2020

Motivation for this change

Without these dependencies:

nix-build -A python3Packages.avro-python3

fails with

WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x7ffff5da2430>: Failed to establish a new connection: [Errno -2] Name or service not known')': /simple/pycodestyle/

and the same for isort.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@clefru
Copy link
Contributor Author

clefru commented Oct 2, 2020

@GrahamcOfBorg build python3Packages.avro-python3

@ofborg ofborg bot requested a review from shlevy October 2, 2020 19:55
@clefru
Copy link
Contributor Author

clefru commented Oct 5, 2020

Adding @shlevy @ktrsoft as maintainers of avro-python3

jonringer
jonringer reviewed Oct 5, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

python3Packages.avro-python3: Add missing dependencies

@clefru
Copy link
Contributor Author

clefru commented Oct 6, 2020

@jonringer : Sorry, I wasn't aware that python3Packages needs to be included. I updated the commit message.

@ofborg ofborg bot requested a review from shlevy October 6, 2020 15:59
@jonringer
Copy link
Contributor

for this package, python is in the name, but for others there's a pkgconfig and a python3Packages.pkgconfig and they do point to different packages

jonringer
jonringer approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99397 1

2 packages built:
  • python37Packages.avro-python3
  • python38Packages.avro-python3

@jonringer jonringer merged commit 063c756 into NixOS:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@ktrsoft ktrsoft ktrsoft approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@shlevy shlevy Awaiting requested review from shlevy

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clefru @jonringer @shlevy @ktrsoft