Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/ssm-agent: fix service configuration #99404

Closed
wants to merge 1 commit into from
Closed

nixos/ssm-agent: fix service configuration #99404

wants to merge 1 commit into from

Conversation

mkurkov
Copy link

@mkurkov mkurkov commented Oct 2, 2020

Motivation for this change

Fix for bug in service configuration that prevents using ssm-agent module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [] Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member

aanderse commented Oct 3, 2020 •
edited

This service is running as root and doesn't utilize the ssm-user user.

@manveru do you know if this service is supposed to be running as root?

@aanderse aanderse mentioned this pull request Oct 3, 2020
Closed
This was referenced Oct 3, 2020
Closed
Merged
@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@mkurkov
Copy link
Author

mkurkov commented Jul 20, 2021

Closing in favor of #99520

@mkurkov mkurkov closed this Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkurkov @aanderse @SuperSandro2000 @Janik-Haag