grub2: Properly disable zfs by default #99386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test zfs |
|
@Mic92 I don't really understand the logs but it seems like the grub tests didn't run. Should I rebase or something? Also is it normal that the logs for the zfs tests are empty for me? |
|
Yeah. I think it should be |
mohe2015
force-pushed
the
smaller-system
branch
from
f9ff8d1
to
d44c621
Compare
This comment has been minimized.
This comment has been minimized.
which is only like 6 MB difference. Although this is a much less minimal system which is likely the reason for that. (TODO @mohe2015 test with a more minimal system) For the test I already set the memory higher ( |
|
Right the installer test seems broken. |
It seems it is now required to set Not sure if improvements can be easily made here, but detecting automatically if |
mohe2015
added a commit
to mohe2015/nixpkgs
that referenced
this pull request
Mar 20, 2021
… grub if they didn't add zfs to boot.initrd.supportedFilesystems See NixOS#99386
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Make the system derivation smaller.
Minimal closure size change: 773,395648 MB -> 672,400544 MB (If I measured correctly)
Things done
I don't know if this is the proper change or if this breaks peoples system.
https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/tasks/filesystems/zfs.nix#L450 seems to enable zfsSupport if needed. https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/system/boot/loader/grub/grub.nix#L16 overrides zfsSupport to true if needed and the default is used otherwise (https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/system/boot/loader/grub/grub.nix#L21).
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)