Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php74: 7.4.8 -> 7.4.11 #99376

Merged
merged 1 commit into from Oct 3, 2020
Merged

php74: 7.4.8 -> 7.4.11 #99376

merged 1 commit into from Oct 3, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Oct 2, 2020

Motivation for this change

https://www.php.net/ChangeLog-7.php#7.4.9
https://www.php.net/ChangeLog-7.php#7.4.10
https://www.php.net/ChangeLog-7.php#7.4.11

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu requested a review from a team October 2, 2020 11:03
@etu
Copy link
Contributor Author

etu commented Oct 2, 2020

@ofborg build php74 php74.tests

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Anyone have a darwin machine they could test the build of this on?

Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Currently building it on an older Mac machine we have in the office as it's unused on weekends %)

@Ma27
Copy link
Member

Ma27 commented Oct 3, 2020

On x86_64-darwin I get the output-path /nix/store/6yx6i0lzaka1x505djaji8nnkdg32jzg-php-with-extensions-7.4.11 for php74. I did some basic usage tests, so it should be good to go. Currently testing php73 on darwin, would backport both after that.

@Ma27 Ma27 merged commit 73cf983 into NixOS:master Oct 3, 2020
@Ma27
Copy link
Member

Ma27 commented Oct 3, 2020

20.09: 07c6f1f
20.03: 960c3fc

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 3, 2020
@etu etu deleted the php74-update branch October 3, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants