django-picklefield: Source from Github, fix test and build #97300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Sep 6, 2020
|
|
||
| # Taken from project's tox.ini | ||
| checkPhase = '' | ||
| python3 -m django test -v3 --settings=tests.settings |
There was a problem hiding this comment.
to support alt interpreters such as pypy
Suggested change
| python3 -m django test -v3 --settings=tests.settings | |
| ${python.interpreter} -m django test -v3 --settings=tests.settings |
There was a problem hiding this comment.
Do I also need to add an import for this?
There was a problem hiding this comment.
you would, if it's not already imported
| src = fetchFromGitHub { | ||
| owner = "gintas"; | ||
| repo = "django-picklefield"; | ||
| rev = "4d5e3b2995df6597d45ad59d92ead38abc5c34af"; |
There was a problem hiding this comment.
please use official releases
Suggested change
| rev = "4d5e3b2995df6597d45ad59d92ead38abc5c34af"; | |
| rev = "v${version}"; |
https://github.com/gintas/django-picklefield/releases/tag/v3.0.1
There was a problem hiding this comment.
Oh, I didn't realize I could batch suggestions. I've incorporated both in now.
m1cr0man
force-pushed
the
django-picklefield
branch
2 times, most recently
from
3aef150
to
bec0913
Compare
jonringer
reviewed
Sep 7, 2020
| @@ -1,16 +1,25 @@ | |||
| { lib, buildPythonPackage, fetchPypi, django }: | |||
| { lib, buildPythonPackage, fetchFromGitHub, django }: | |||
There was a problem hiding this comment.
Suggested change
| { lib, buildPythonPackage, fetchFromGitHub, django }: | |
| { lib, buildPythonPackage, fetchFromGitHub, python, django }: |
to fix eval
m1cr0man
force-pushed
the
django-picklefield
branch
from
bec0913
to
b55db43
Compare
|
Fixed in #97283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This package is required by mailman, and was failing to build, possibly since django 1_11 was dropped.
Things done
Sourced package from GitHub since the Pypi package did not contain any tests, and then configured checkPhase to run these tests.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)