Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airscan: 0.99.8 -> 0.99.16 #97280

Merged
merged 1 commit into from Sep 14, 2020
Merged

airscan: 0.99.8 -> 0.99.16 #97280

merged 1 commit into from Sep 14, 2020

Conversation

tex
Copy link
Contributor

@tex tex commented Sep 6, 2020

Motivation for this change

Update airscan, got support of couple additional scanners. My is WorkCentre 3025 and works now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from zaninime September 6, 2020 15:21
@tomberek
Copy link
Contributor

tomberek commented Sep 8, 2020

LGTM, builds, runs, and functions as expected on NixOS.

@tex
Copy link
Contributor Author

tex commented Sep 14, 2020

Is there anything else I can do to for successful merge?

@zaninime
Copy link
Contributor

@ryantm this PR looks fine to me. Could you please have a look? Thanks.

@ryantm ryantm merged commit 8cdf9c9 into NixOS:master Sep 14, 2020
@tex tex deleted the airscan branch September 15, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@zaninime zaninime zaninime approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tex @tomberek @zaninime @ryantm