Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

busybox: Fix 404 error #97286

Closed
wants to merge 1 commit into from
Closed

busybox: Fix 404 error #97286

wants to merge 1 commit into from

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Sep 6, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@TethysSvensson
Copy link
Contributor

This looks good to me. As far as I can tell, default.script is identical in the new package, and that is the only file currently used.

jonringer
jonringer reviewed Sep 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having the version bump would be more appropriate:

busybox: 1.30.1-5 -> 1.30.1-6, fix 404

otherwise LGTM

@TethysSvensson
Copy link
Contributor

I think having the version bump would be more appropriate:

busybox: 1.30.1-5 -> 1.30.1-6, fix 404

otherwise LGTM

It's not a version bump for the entire busybox package, just for the debian package we are using to get a single script for udhcpc.

The current version for busybox itself is 1.31.1.

@pbogdan
Copy link
Member

pbogdan commented Sep 6, 2020

It could also be fetched from https://salsa.debian.org/installer-team/busybox/ where it should be possible to pin it to a specific git revision so it doesn't disappear in the future (it doesn't seem the file is being updated frequently / with each release).

worldofpeace
worldofpeace suggested changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #97286 (comment). That would be much better.

@TethysSvensson TethysSvensson mentioned this pull request Sep 13, 2020
Merged
10 tasks
@TethysSvensson
Copy link
Contributor

This can be closed now, as it was superseded by #97894.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@HaoZeke @TethysSvensson @pbogdan @jonringer @worldofpeace