chromium: Unblock nixos-unstable by using the correct argument to fet… #97287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
nixos-unstable is currently blocked. See https://hydra.nixos.org/build/126501646 for an example of a failing build.
To reproduce the failure, run:
nix-build pkgs/top-level/release.nix -A unstable --show-trace
The failing call to
nix-instantiate
can be seen here.This fails, because
find-tarballs.nix
expects theurl
argument tofetchurl
to be a string, while theurls
should be used when multiple sources are needed.This commit fixes a single instance of this problem, and this fix seems to be enough to unblock nixos-unstable. I am also preparing a follow-up PR to fix all additional instances of the problem.
CC: @jonringer
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)