Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2020.07.28 -> 2020.09.06 #97278

Merged
merged 1 commit into from Sep 6, 2020
Merged

youtube-dl: 2020.07.28 -> 2020.09.06 #97278

merged 1 commit into from Sep 6, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Sep 6, 2020

https://github.com/ytdl-org/youtube-dl/releases/tag/2020.09.06

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@akamaus
Copy link
Contributor

akamaus commented Sep 6, 2020

Was able to build it. Works, able to download youtube videos.

@Ma27 Ma27 merged commit 9d18073 into NixOS:master Sep 6, 2020
@Ma27
Copy link
Member

Ma27 commented Sep 6, 2020

Thanks! Ported to stable as b0976a3.

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Sep 6, 2020
@zowoq zowoq deleted the youtube-dl branch September 6, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @akamaus @Ma27