Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zola: 0.11.0 -> 0.12.0 #97269

Merged
merged 1 commit into from Sep 6, 2020
Merged

zola: 0.11.0 -> 0.12.0 #97269

merged 1 commit into from Sep 6, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Sep 6, 2020

Motivation for this change

https://github.com/getzola/zola/releases/tag/v0.12.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tomberek
Copy link
Contributor

tomberek commented Sep 6, 2020

builds on NixOS, runs and tested basic function. Basic version bump and adds a dependency.
My only question is if RUSTONIG_SYSTEM_LIBONIG is needed, but others will have more experience about this than me.

@danieldk
Copy link
Contributor

danieldk commented Sep 6, 2020

My only question is if RUSTONIG_SYSTEM_LIBONIG is needed, but others will have more experience about this than me.

I think we should prefer dynamic linking and the crate only works with an environment variable. They don't add a system function as is commonly done by such crates:

https://github.com/rust-onig/rust-onig/blob/7610549966d95b984dc95cf71469d8fcada689d7/onig_sys/Cargo.toml#L31

Maybe it is worthwhile opening an issue upstream to ask them to make it possible to enable this with a feature as well? (Not that it would help us much in this case, since it would be a feature of a transitive dependency.)

@ofborg ofborg bot requested a review from dywedir September 6, 2020 09:39
@danieldk danieldk merged commit 0df5508 into NixOS:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@dywedir dywedir Awaiting requested review from dywedir

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @tomberek @danieldk