nixos/lorri: add package option #97314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profpatsch
approved these changes
Sep 7, 2020
evanjs
added a commit
to evanjs/nixos_cfg
that referenced
this pull request
Sep 17, 2020
- Now that lorri provides a package option (NixOS/nixpkgs#97314), utilize this to set the package used by the service - Note: this is disabled until we encounter a change that requires the master branch, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Sometimes I need
lorrito track master for changes that have not yet made it into nixpkgs.Previously, I did this by overriding
srcas shown here.As of target/lorri#168 / target/lorri@0ccdfa7, this is no longer possible.
I did try to utilize
overrideAttrs, but encountered issues simply setting therevand etc., due to the nature of lorri'ssrc.Things done
packageoption to thelorrimodulenixos-rebuild switch -I nixpkgs=.(from a localnixpkgsclone)