Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiledb: 1.7.7 -> 2.0.7, pythonPackages.tiledb: 0.5.6 -> 0.6.6, enable for darwin along with libpqxx #97253

Merged
merged 4 commits into from Sep 6, 2020
Merged

tiledb: 1.7.7 -> 2.0.7, pythonPackages.tiledb: 0.5.6 -> 0.6.6, enable for darwin along with libpqxx #97253

merged 4 commits into from Sep 6, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 5, 2020 •
edited

Motivation for this change

This supersedes #94330. The tiledb bump also requires a corresponding bump to the python package.

At the same time I fixed/enabled it for non-x86 linux and darwin (tested macos 10.14). The latter first required enabling libpqxx for darwin, which turns out to work just fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 5, 2020
@risicle
Copy link
Contributor Author

risicle commented Sep 5, 2020

@ofborg build tiledb python37Packages.tiledb

@ofborg ofborg bot requested review from Rakesh4G, edolstra and FRidh September 5, 2020 20:01
@risicle
Copy link
Contributor Author

risicle commented Sep 5, 2020 •
edited

@ofborg build tiledb python37Packages.tiledb cloudcompare pdal

@risicle risicle marked this pull request as ready for review September 5, 2020 22:02
@FRidh FRidh merged commit e7710c9 into NixOS:master Sep 6, 2020
@sikmir sikmir mentioned this pull request Oct 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakesh4G Rakesh4G Awaiting requested review from Rakesh4G

@edolstra edolstra Awaiting requested review from edolstra

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @FRidh @r-ryantm