Skip to content

nixos/cinnamon: init #97256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Sep 7, 2020
Merged

nixos/cinnamon: init #97256

merged 25 commits into from
Sep 7, 2020
+486 −161

Conversation

mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Sep 5, 2020

Motivation for this change

Make it happen ™️

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 5, 2020
@ofborg ofborg bot requested a review from romildo September 5, 2020 21:36
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 5, 2020
@mkg20001 mkg20001 force-pushed the cinnamon-module branch 2 times, most recently from 495ae74 to 526ceef Compare September 5, 2020 22:41
@ofborg ofborg bot added the 6.topic: cinnamon Desktop environment label Sep 5, 2020
@mkg20001 mkg20001 force-pushed the cinnamon-module branch 2 times, most recently from e3fe2b2 to dc0c457 Compare September 6, 2020 14:31
@mkg20001
Copy link
Member Author

mkg20001 commented Sep 6, 2020

image
image

@mkg20001
cinnamon.mint-x-icons: init at 1.5.5

Verified

This commit was signed with the committer’s verified signature. The key has expired.
grahamc Graham Christensen
GPG key ID: ACA1C1D120C83D5C
Expired
Verified
Learn about vigilant mode
a5a97c3
@mkg20001
mint-artwork: init at 1.4.3

Verified

This commit was signed with the committer’s verified signature.
vcunat Vladimír Čunát
GPG key ID: E747DF1F9575A3AA
Verified
Learn about vigilant mode
4da4af4
@mkg20001
cinnamon.cinnamon-gsettings-overrides: init

Verified

This commit was signed with the committer’s verified signature.
vcunat Vladimír Čunát
GPG key ID: E747DF1F9575A3AA
Verified
Learn about vigilant mode
c08e45f
@mkg20001
vanilla-dmz: 0.4.4 -> 0.4.5 (+license fix)
b5839da 
The package debian/copyright states Attribution-ShareAlike 3.0 Unported 
(CC BY-SA 3.0) which is cc-by-sa-30, was wrongly cc-by-nc-sa-30 which is 
unfree
@mkg20001
mint-x-icons: remove other package and expose from cinnamon namespace
996bdf7
@mkg20001
cinnamon.cinnamon-settings-daemon: add dev output
907f761
@worldofpeace worldofpeace changed the title modules.cinnamon: add cinnamon module nixos/cinnamon: init Sep 7, 2020
@mkg20001 mkg20001 force-pushed the cinnamon-module branch 3 times, most recently from ca1bdc5 to 6ba142e Compare September 7, 2020 23:16
@worldofpeace
Copy link
Contributor

worldofpeace commented Sep 7, 2020 •
edited
Loading

There's a path to the onboard theme in the mint-artwork override that isn't patched right
theme='/nix/store/bxv49xfvc0m5kxbrd03bsl4hj5xr0j5p-mint-artwork-1.4.3/share/mint-artwork/onboard/Nightshade.theme'
that belongs to onboard

@mkg20001 mkg20001 force-pushed the cinnamon-module branch 2 times, most recently from 5acf2f9 to 6d2c15f Compare September 7, 2020 23:30
@worldofpeace
Copy link
Contributor

There's a path to the onboard theme in the mint-artwork override that isn't patched right
theme='/nix/store/bxv49xfvc0m5kxbrd03bsl4hj5xr0j5p-mint-artwork-1.4.3/share/mint-artwork/onboard/Nightshade.theme'
that belongs to onboard

Turns out this does exist. It seems they changed the Nightshade theme from onboard in an almost imperceptible way. I guess too little for us to care about.

@mkg20001 @worldofpeace
nixos/cinnamon: init
04ea3a0 
Co-Authored-By: WORLDofPEACE <worldofpeace@protonmail.ch>
@ofborg ofborg bot requested a review from romildo September 7, 2020 23:47
@worldofpeace worldofpeace merged commit fcc395d into NixOS:master Sep 7, 2020
This was referenced Sep 8, 2020
Merged
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@cstrahan cstrahan

@romildo romildo

Assignees
No one assigned
Labels
6.topic: cinnamon Desktop environment 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkg20001 @worldofpeace @romildo @r-ryantm