Not sure who to ping, so @infinisil pardon me :p

As a general remark, it's a bit annoying that such a critical module doesn't have any maintainers listed.

using "none" as a default was not to my taste in the end (also it prevented having a banner with the content "none") so I made null the default as you initally suggested. My next concern is that Banner expecting a path, maybe it would be best to just accept a path instead of lines ? (though I think in 90% cases, lines is more convenient).

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

1. Search for maintainers and people that previously touched the
   related code and @ mention them in a comment.
2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
   irc.freenode.net.

Can you squash the commits into one? Will merge after that :)

@infinisil what's the difference with squashing from GH's UI ?

• It maintains the original commit sha1 and signature if there is one
• Squash button creates a single commit, which isn't always ideal
• With the squash button I have to combine commit messages, even though these aren't any of my commits

thank you for the explanation. Squashed :)