python3Packages.tensorboardx: fix build after upgrade to PyTorch 1.6 #97261
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: python
11.by: package-maintainer
danieldk
reviewed
Sep 6, 2020
akamaus
force-pushed
the
tensorboardx-pytorch1.6-repair
branch
from
4d293eb to
9ff9e3a
Compare
|
2 months passed and we still have broken tensorboardX in master. |
danieldk
force-pushed
the
tensorboardx-pytorch1.6-repair
branch
from
9ff9e3a to
16273d2
Compare
danieldk
changed the title
jonringer
reviewed
Nov 10, 2020
Comment on lines
+23
to
+25
| postPatch = '' | ||
| substituteInPlace tensorboardX/pytorch_graph.py --replace "torch.onnx.set_training(model, False)" "torch.onnx.select_model_mode_for_export(model, torch.onnx.TrainingMode.EVAL)" | ||
| ''; |
There was a problem hiding this comment.
for readability
Suggested change
| postPatch = '' | |
| substituteInPlace tensorboardX/pytorch_graph.py --replace "torch.onnx.set_training(model, False)" "torch.onnx.select_model_mode_for_export(model, torch.onnx.TrainingMode.EVAL)" | |
| ''; | |
| postPatch = '' | |
| substituteInPlace tensorboardX/pytorch_graph.py \ | |
| --replace "torch.onnx.set_training(model, False)" \ | |
| "torch.onnx.select_model_mode_for_export(model, torch.onnx.TrainingMode.EVAL)" | |
| ''; |
|
does bumping this to 2.1 fix this? |
See |
danieldk
force-pushed
the
tensorboardx-pytorch1.6-repair
branch
from
16273d2 to
0223525
Compare
|
@ofborg build python37Packages.tensorboardx python38Packages.tensorboardx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Torch ONNX api changed a bit in 1.6 version. TensorboardX build fails now.
Things done
Tweaked code a bit so test works again.
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)