Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nushell: enable for aarch64 #97262

Merged
merged 1 commit into from Sep 6, 2020
Merged

nushell: enable for aarch64 #97262

merged 1 commit into from Sep 6, 2020

Conversation

colemickens
Copy link
Member

Motivation for this change

Bump nushell to latest.
Enable for aarch64, since it seemed to just work on the community builder.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author

cc: @L-as

@colemickens colemickens changed the title nushell: 0.8.3->0.9.0, enable for aarch64 nushell: enable for aarch64 Sep 5, 2020
@colemickens colemickens mentioned this pull request Sep 5, 2020
Closed
@ofborg ofborg bot requested review from Br1ght0ne and marsam September 6, 2020 01:39
marsam
marsam reviewed Sep 6, 2020
View reviewed changes
pkgs/shells/nushell/default.nix
@@ -51,7 +51,7 @@ rustPlatform.buildRustPackage rec {
homepage = "https://www.nushell.sh/";
license = licenses.mit;
maintainers = with maintainers; [ filalex77 johntitor marsam ];
platforms = [ "x86_64-linux" "i686-linux" "x86_64-darwin" ];
platforms = [ "x86_64-linux" "i686-linux" "x86_64-darwin" "aarch64-linux" ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can assume it builds on all platforms

Suggested change
platforms = [ "x86_64-linux" "i686-linux" "x86_64-darwin" "aarch64-linux" ];

@Ma27 Ma27 merged commit f01fd49 into NixOS:master Sep 6, 2020
@colemickens colemickens deleted the nushell branch December 30, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@colemickens @marsam @Ma27