Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicity: 0.8.13 -> 0.8.15 #97268

Merged
merged 1 commit into from Dec 29, 2020
Merged

duplicity: 0.8.13 -> 0.8.15 #97268

merged 1 commit into from Dec 29, 2020

Conversation

StephenWithPH
Copy link
Contributor

Motivation for this change

Updates duplicity to current stable 0.8 release 0.8.15, released July 27, 2020.

cc @peti

Note that the patch change corresponds to https://gitlab.com/duplicity/duplicity/-/commit/6b7a2b06694725fa5d780701413878366de14546

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tomberek
Copy link
Contributor

tomberek commented Sep 6, 2020

Build on NixOS, runs and functions as expected. Version bump and patch update.

@ofborg ofborg bot requested a review from peti September 6, 2020 07:10
@jtojnar
Copy link
Contributor

jtojnar commented Sep 6, 2020

Changelog: https://gitlab.com/duplicity/duplicity/-/blob/rel.0.8.15/CHANGELOG#L1-62

@jtojnar
Copy link
Contributor

jtojnar commented Sep 6, 2020

We might want to replace pydrive by pydrive2 but that is not packaged.

@StephenWithPH StephenWithPH mentioned this pull request Sep 8, 2020
Closed
10 tasks
@StephenWithPH
Copy link
Contributor Author

We might want to replace pydrive by pydrive2 but that is not packaged.

@jtojnar ... I'm taking a crack at that. Having some nix Python 2 vs 3 errors that are surprisingly hard (for me... so far) to find answers to in Nix docs or Discourse. I'll keep working at it for a bit.

@StephenWithPH
Copy link
Contributor Author

We might want to replace pydrive by pydrive2 but that is not packaged.

I finished (I hope!) the PR for pydrive2; it's linked earlier in this PR. Of note, I had to make it Python 3 only due to:

nixpkgs/pkgs/development/python-modules/google_api_core/default.nix

Line 9 in 33402a8

disabled = isPy27; # google namespace no longer works on python2

Duplicity currently builds for both 2 and 3. I assume that moving Duplicity to pydrive2 implies either Python 3 only or some fancy switching based on context. Thoughts?

Of note, a thread on Duplicity's mailing list hints that Python 2 support might be dropped at some point:

Pure Python 3 code will not be that difficult. Better testing would help a lot.

Yes, 0.8 is stable, once we got a handle on handling unicode in exceptions. Yet again, more testing is needed.

Other than getting setup.py to handle dual versions during install, I see no problem with supporting 0.8 for a while longer. We will have to bite the bullet at some point, but we're not there yet.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 97268 run on x86_64-darwin 1

2 packages built:
  • duplicity
  • duply

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 97268 run on x86_64-linux 1

3 packages built:
  • deja-dup
  • duplicity
  • duply

@SuperSandro2000 SuperSandro2000 merged commit e3bca76 into NixOS:master Dec 29, 2020
@StephenWithPH StephenWithPH deleted the duplicity_0.8.15 branch December 31, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StephenWithPH @tomberek @jtojnar @SuperSandro2000