Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elasticmq-server: 0.14.6 -> 1.2.0, add passthru.tests #97299

Merged
merged 3 commits into from Sep 1, 2021
Merged

elasticmq-server: 0.14.6 -> 1.2.0, add passthru.tests #97299

merged 3 commits into from Sep 1, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 6, 2020

Motivation for this change

Added quite a simple test to check basic operation of the queue.

Still, it's the first passthru.tests I've written, and I don't know whether e.g. detaching a process here is considered "ok". It feels a little less wrong than doing it in checkPhase.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor Author

risicle commented Sep 6, 2020

@ofborg build elasticmq-server-bin elasticmq-server-bin.tests

@SuperSandro2000
Copy link
Member

@risicle please resolve the merge conflict.

@risicle risicle force-pushed the ris-elasticmq-server-0.15.7-tests branch from 799c330 to 49eb812 Compare January 18, 2021 19:21
@risicle
Copy link
Contributor Author

risicle commented Jan 18, 2021

@ofborg build elasticmq-server-bin elasticmq-server-bin.tests

@risicle risicle force-pushed the ris-elasticmq-server-0.15.7-tests branch from 49eb812 to 8cf31d0 Compare January 18, 2021 21:04
@doronbehar
Copy link
Contributor

Result of nixpkgs-review pr 97299 run on x86_64-linux 1

1 package built:
  • elasticmq-server-bin

@stale
Copy link

stale bot commented Aug 28, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 28, 2021
@doronbehar
Copy link
Contributor

@risicle perhaps now we should update to https://github.com/softwaremill/elasticmq/releases/tag/v1.2.0 ?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 30, 2021
@risicle
Copy link
Contributor Author

risicle commented Aug 30, 2021

Totally forgot about this. Yes, perhaps.

@risicle risicle force-pushed the ris-elasticmq-server-0.15.7-tests branch from 8cf31d0 to 5a94051 Compare August 31, 2021 21:40
@risicle
elasticmq-server-bin: add passthru.tests.elasticmqTest
9c77351 
simply starts an elasticmq server with a queue "foobar", attempts to put
a message to it from python then checks it arrives
@risicle
elasticmq-server-bin: 0.15.7 -> 1.2.0
0fec93a
@risicle risicle force-pushed the ris-elasticmq-server-0.15.7-tests branch from 5a94051 to 0fec93a Compare August 31, 2021 23:04
@risicle risicle changed the title elasticmq-server: 0.14.6 -> 0.15.7, add passthru.tests elasticmq-server: 0.14.6 -> 1.2.0, add passthru.tests Aug 31, 2021
@risicle
Copy link
Contributor Author

risicle commented Aug 31, 2021

Rebased, bumped, tests pass on nixos x86_64 and macos 10.15

@risicle risicle merged commit 6aef13b into NixOS:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @SuperSandro2000 @doronbehar