Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joplin-desktop: 1.0.233 -> 1.0.241 #97309

Merged
merged 1 commit into from Sep 8, 2020
Merged

joplin-desktop: 1.0.233 -> 1.0.241 #97309

merged 1 commit into from Sep 8, 2020

Conversation

placeybordeaux
Copy link
Contributor

Motivation for this change

Update joplin-desktop to latest version

Things done

Update version number & sha256

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from HugoReeves September 7, 2020 02:55
HugoReeves
HugoReeves approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@HugoReeves HugoReeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HugoReeves
Copy link
Member

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from HugoReeves September 8, 2020 05:06
@danieldk danieldk force-pushed the placeybordeaux/update-joplin-desktop branch from e577b16 to a634d70 Compare September 8, 2020 15:41
@danieldk danieldk changed the title joplin-desktop 1.0.233 -> joplin-desktop 1.0.241 joplin-desktop: 1.0.233 -> 1.0.241 Sep 8, 2020
@danieldk
Copy link
Contributor

danieldk commented Sep 8, 2020 •
edited

Thanks! Note that the commit message was incorrect, the correct template is:

attribute: oldVersion -> newVersion

As described in CONTRIBUTING.md

@danieldk danieldk merged commit 33402a8 into NixOS:master Sep 8, 2020
@placeybordeaux
Copy link
Contributor Author

Huh I thought the the commit message

joplin-desktop: 1.0.233 -> 1.0.241

Conformed to

attribute: oldVersion -> newVersion

What did I miss?

@danieldk
Copy link
Contributor

danieldk commented Sep 9, 2020

Huh I thought the the commit message

joplin-desktop: 1.0.233 -> 1.0.241

Conformed to

attribute: oldVersion -> newVersion

That was after I updated it, before it was

joplin-desktop 1.0.233 -> joplin-desktop 1.0.241

@placeybordeaux
Copy link
Contributor Author

placeybordeaux commented Sep 9, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HugoReeves HugoReeves HugoReeves approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@placeybordeaux @HugoReeves @danieldk @Janik-Haag