Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticmq: remove in favour of elasticmq-server #97291

Merged
merged 1 commit into from Jan 17, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 6, 2020

Motivation for this change

The elasticmq package is very old and hasn't seen any non-automatic updates since its introduction (in 2012). Newer releases are packaged as elasticmq-server.

Bit of a head-scratcher how we added the new one seemingly without noticing the old one (?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor

bhipple commented Oct 30, 2020

This has a merge conflict, but otherwise looks like a nice improvement. Can you rebase and then I'll merge? Might be reasonable to add a it to aliases.nix with a legacy removed comment too.

@SuperSandro2000
Copy link
Member

You forgot to add the alias.

the elasticmq package is very old and hasn't seen any non-automatic updates
since its introduction. newer releases are packaged as elasticmq-server
@risicle
Copy link
Contributor Author

risicle commented Jan 17, 2021

Done

@SuperSandro2000 SuperSandro2000 merged commit f42fb61 into NixOS:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants