Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailpile: 1.0.0rc2 -> 1.0.0rc6 #97274

Closed
wants to merge 1 commit into from
Closed

Conversation

Twey
Copy link
Contributor

@Twey Twey commented Sep 6, 2020

This PR also removes the meta.knownVulnerabilities metadata from the package. The referenced discussion thread talks about 0.5.x versions of Mailpile; 1.0.0rc* are stated to be ready for packaging.

Atop #97273.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

also, partial duplicate of #97273

@Twey
Copy link
Contributor Author

Twey commented Sep 7, 2020

Yes, I intended for #97273 to be merged first, then this atop it — sorry, thought I'd made that clear in the description, but I guess I forgot.

@jonringer
Copy link
Contributor

please rebase on the latest master, and remove the imgsize commit

@Twey
Copy link
Contributor Author

Twey commented Sep 8, 2020

Have done — eval failure is due to master.

@jonringer
Copy link
Contributor

there was fixup commit already pushed, do you mind rebasing again?

@Twey
Copy link
Contributor Author

Twey commented Sep 9, 2020

Done!

{ stdenv, fetchFromGitHub, python2Packages, gnupg1orig, openssl, git }:
{ stdenv
, fetchFromGitHub
, python2Packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be updated to python3?

Copy link

@reyman reyman Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about that, mailpile 1.0 target python 3+, actually don't know where dev are on this point, i ask here : mailpile/Mailpile#160

@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@ostylk ostylk mentioned this pull request Sep 11, 2021
12 tasks
mweinelt added a commit to mweinelt/nixpkgs that referenced this pull request Jan 16, 2022
Still actively developed and yet stuck on python2. Also marked as
vulnerable and their issue tracker contains yet another security issue
reported in 2021/10 that the upstream hasn't acknowledged yet.

Mind blown.

Closes: NixOS#135543, NixOS#97274, NixOS#97275
@rapenne-s
Copy link
Member

mailpile has been removed 369db3b

@rapenne-s rapenne-s closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants