Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rainloop service: init #97272

Closed
wants to merge 2 commits into from
Closed

rainloop service: init #97272

wants to merge 2 commits into from

Conversation

Twey
Copy link
Contributor

@Twey Twey commented Sep 6, 2020 •
edited

This pull request introduces a service for running (multiple instances of) the rainloop webmail client.

It sits atop #97271.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Twey Twey changed the title Rainloop service rainloop service: init Sep 6, 2020
@ofborg ofborg bot requested a review from dasJ September 6, 2020 12:09
doronbehar
doronbehar reviewed Sep 11, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, but diff looks good.

nixos/modules/services/mail/rainloop.nix Outdated Show resolved Hide resolved
nixos/modules/services/mail/rainloop.nix Outdated Show resolved Hide resolved
@Twey Twey force-pushed the rainloop-service branch 2 times, most recently from d9461f6 to 34542c4 Compare September 11, 2020 17:55
@doronbehar
Copy link
Contributor

Thank you for your contribution @Twey. I don't know a thing about PHP and nginx related services in Nixpkgs but I'd like to help you, and the changes look good. Considering also #97271, perhaps you could write a nixos test that will test the features you'd like to add? It's common to do so when adding new services.

@stale
Copy link

stale bot commented Mar 16, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 16, 2021
@doronbehar
Copy link
Contributor

Closing due to OP not responding.

@doronbehar doronbehar closed this May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar left review comments

@dasJ dasJ Awaiting requested review from dasJ

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Twey @doronbehar