Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: add README.md explaining the configuration #532

Merged
merged 1 commit into from Oct 6, 2020

Conversation

andir
Copy link
Member

@andir andir commented Oct 5, 2020

It was lost in the Not you: team change. It probably makes sense to
keep this documented as people involved in this project might change
over time and sometimes memory can also be blurry :)

cc @grahamc @cole-h

php/README.md Outdated Show resolved Hide resolved
It was lost in the `Not you: team` change. It probably makes sense to
keep this documented as people involved in this project might change
over time and sometimes memory can also be blurry :)
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@andir
Copy link
Member Author

andir commented Oct 6, 2020

@cole-h anything left before merging? I can't merge things here ^^

@cole-h
Copy link
Member

cole-h commented Oct 6, 2020

Oops, sorry, forgot to actually hit the button :D

@cole-h cole-h merged commit b405973 into NixOS:released Oct 6, 2020
@andir andir deleted the readd-php-config-example branch October 6, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants