Php update #531
Closed
Php update #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
php72 no longer exists on unstable.
This update was accomplished by running the following:
nix-shell -p phpPackages.composer --run 'composer update'
$(nix-build ~/workspace/vcs/composer2nix/release.nix -A package.x86_64-linux)/bin/composer2nix
|
We probably do not have to pin it but should write a test for it. We should be able to test it without waiting for breakage in prod. |
|
Isn't that what Hydra is doing for us? Or do you mean a functionality test, and not a "does it build" test? |
|
Yeah, an actual functional test. I started writing on earlier today. Might
PR it tomorrow.
…On Mon, 5 Oct 2020, 19:34 Cole Helbling, ***@***.***> wrote:
Isn't that what Hydra is doing for us? Or do you mean a functionality
test, and not a "does it build" test?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#531 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE365FKCOJZKC5UHSAUJULSJH7SJANCNFSM4SEKCUIQ>
.
|
|
I believe this is superceded by #563. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the Hydra jobset for ofborg was failing because
php72is gone (https://hydra.nixos.org/jobset/ofborg/release#tabs-errors).Did literally nothing to test aside from
nix-build -A ofborg.php.cc @andir -- should we pin php again? There is
php73andphp74to choose from, at the moment.