Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmlsort: missing dependency #99610

Merged
merged 1 commit into from Oct 5, 2020
Merged

xmlsort: missing dependency #99610

merged 1 commit into from Oct 5, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

hot"fixes" are the absolutely worst....

Cc: @stigtsp

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

Further to #99606 and d6684be

@stigtsp
Copy link
Member

stigtsp commented Oct 5, 2020

@GrahamcOfBorg build perlPackages.XMLFilterSort perldevelPackages.XMLFilterSort

@stigtsp
Copy link
Member

stigtsp commented Oct 5, 2020

Built and tested OK on darwin x64

stigtsp
stigtsp approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stigtsp stigtsp merged commit e324e25 into NixOS:master Oct 5, 2020
@peterhoeg peterhoeg deleted the f/xmlsort branch October 5, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @stigtsp