Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmlbird: fix build with python 3.8 #98298

Merged
merged 2 commits into from Sep 20, 2020
Merged

xmlbird: fix build with python 3.8 #98298

merged 2 commits into from Sep 20, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 19, 2020

Motivation for this change

ZHF: #97479

Also fix a similar bug in birdfont (xmlbird's only reverse-dependency) which would cause build to fail on debian-based non-nixos systems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
xmlbird: fix build with python 3.8
0628450 
also force use of gccStdenv to fix darwin build
@risicle
birdfont: fix build on non-nixos/debian systems
2eafdb6 
to do this we need to prevent platform.version() from using uname to
discover this is a debian kernel and try dpkg nonsense
@ofborg ofborg bot requested a review from dtzWill September 19, 2020 22:01
@jonringer
Copy link
Contributor

interesting... wonder if there's a way to fix this more broadly for nixos

However, this would also mean that users which are non-nixos linux would also see their distribution as "nix". But I'm not sure if that's a terrible thing, as nix essentially act as a guest OS

@risicle
Copy link
Contributor Author

risicle commented Sep 20, 2020 •
edited

It had crossed my mind to consider how we could sandbox uname. Or if not sandbox, best-effort spoof it. An LD_PRELOAD hack would work but I can't imagine how we'd ensure it's applied universally.

Or simply patch our glibc's uname implementation to listen out for a NIX_SPOOF_UNAME environment variable we set for sandboxed builds.

jonringer
jonringer approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98298 1

2 packages built:
  • birdfont
  • xmlbird

@jonringer jonringer merged commit 0b67d9e into NixOS:master Sep 20, 2020
@jonringer
Copy link
Contributor

I think this is a pretty uncommon scenario. Just patching it like this should be fine.

@risicle risicle mentioned this pull request Sep 20, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer