Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.irc: add toml build time dependency #98248

Closed
wants to merge 1 commit into from
Closed

pythonPackages.irc: add toml build time dependency #98248

wants to merge 1 commit into from

Conversation

mweinelt
Copy link
Member

Motivation for this change

Requires setuptools_scm[toml], only setuptools_scm was given. Added toml, satisfied the build.

https://hydra.nixos.org/build/126797031/nixlog/1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 19, 2020
@mweinelt
Copy link
Member Author

Already fixed in 7567bd6.

@mweinelt mweinelt closed this Sep 19, 2020
@mweinelt mweinelt deleted the python/irc branch September 19, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mweinelt