Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmuxPlugins.nord: init at 0.3.0 #98246

Merged
merged 1 commit into from Sep 19, 2020
Merged

tmuxPlugins.nord: init at 0.3.0 #98246

merged 1 commit into from Sep 19, 2020

Conversation

hongchangwu
Copy link
Contributor

@hongchangwu hongchangwu commented Sep 19, 2020 •
edited

Motivation for this change

Nord tmux is an arctic, north-bluish clean and elegant tmux color theme based on the Nord color palette.

Repo: https://github.com/arcticicestudio/nord-tmux

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions: Ubuntu
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

AndersonTorres
AndersonTorres approved these changes Sep 19, 2020
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndersonTorres AndersonTorres merged commit 198cd8e into NixOS:master Sep 19, 2020
@hongchangwu hongchangwu deleted the tmuxPlugins.tmux branch September 19, 2020 07:56
@hongchangwu
Copy link
Contributor Author

Thanks!

@humancalico
Copy link
Member

Hey @hongchangwu. Can you tell me how do you test the tmux plugins that you add to nixpkgs. I am trying to add the dracula theme for tmux and it builds alright with the nix-build -A pkg-attribute-name <path to your local nixpkgs folder>/default.nix command but I am unable to figure out how to test it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hongchangwu @humancalico @AndersonTorres @Janik-Haag