Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] haskellPackages.sbv: fix tests #98269

Merged
merged 1 commit into from Sep 20, 2020
Merged

[20.09] haskellPackages.sbv: fix tests #98269

merged 1 commit into from Sep 20, 2020

Conversation

KaiHa
Copy link
Contributor

@KaiHa KaiHa commented Sep 19, 2020

By patching paths of the external provers and excluding not available
provers from the test.

ZHF: #97479
(cherry picked from commit f40afea)

Motivation for this change

ZHF

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KaiHa
haskellPackages.sbv: fix tests
0c9bbf8 
By patching paths of the external provers and excluding not available
provers from the test.

ZHF: NixOS#97479
(cherry picked from commit f40afea)
@KaiHa
Copy link
Contributor Author

KaiHa commented Sep 19, 2020

Ping @NixOS/nixos-release-managers

@cdepillabout
Copy link
Member

Looks good, thanks for backporting this!

@cdepillabout cdepillabout merged commit 187a2da into NixOS:release-20.09 Sep 20, 2020
@worldofpeace worldofpeace changed the title haskellPackages.sbv: fix tests [20.09] haskellPackages.sbv: fix tests Sep 20, 2020
@KaiHa KaiHa deleted the pr/sbv-backport branch September 20, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout cdepillabout is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KaiHa @cdepillabout