Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] Revert "nixos/monit: Allow splitting the config in multiple files" #98260

Merged
merged 1 commit into from Sep 19, 2020
Merged

[20.09] Revert "nixos/monit: Allow splitting the config in multiple files" #98260

merged 1 commit into from Sep 19, 2020

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Sep 19, 2020

(cherry picked from commit 61863c5)

Motivation for this change

These changes are unnecessary and make it harder to use monit. More details at #87553

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member Author

ryantm commented Sep 19, 2020

cc @Lassulus @JoeDupuis @NixOS/nixos-release-managers

@ryantm ryantm changed the title Revert "nixos/monit: Allow splitting the config in multiple files" [20.09] Revert "nixos/monit: Allow splitting the config in multiple files" Sep 19, 2020
@worldofpeace worldofpeace merged commit 76266a5 into NixOS:release-20.09 Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryantm @worldofpeace