Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.junos_eznc: fix build by packaging missing dependencies #98253

Merged
merged 4 commits into from Sep 20, 2020
Merged

pythonPackages.junos_eznc: fix build by packaging missing dependencies #98253

merged 4 commits into from Sep 20, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

ZHF #97479

https://hydra.nixos.org/build/126782361

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 19, 2020
@mweinelt
Copy link
Member Author

Result of nixpkgs-review pr 98253 1

10 packages built:
  • python27Packages.textfsm
  • python27Packages.yamlordereddictloader
  • python37Packages.junos-eznc
  • python37Packages.ntc-templates
  • python37Packages.textfsm
  • python37Packages.yamlordereddictloader
  • python38Packages.junos-eznc
  • python38Packages.ntc-templates
  • python38Packages.textfsm
  • python38Packages.yamlordereddictloader

@risicle
Copy link
Contributor

risicle commented Sep 19, 2020

LGTM, WFM macos 10.14 & linux x86_64

@ofborg build python37Packages.junos_eznc python38Packages.junos_eznc python27Packages.textfsm python27Packages.yamlordereddictloader

@mweinelt
Copy link
Member Author

Fixed up meta.maintainers in textfsm and yamlordereddictloader.

jonringer
jonringer approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98253 1

10 packages built:
  • python27Packages.textfsm
  • python27Packages.yamlordereddictloader
  • python37Packages.junos-eznc
  • python37Packages.ntc-templates
  • python37Packages.textfsm
  • python37Packages.yamlordereddictloader
  • python38Packages.junos-eznc
  • python38Packages.ntc-templates
  • python38Packages.textfsm
  • python38Packages.yamlordereddictloader

@jonringer jonringer merged commit a5f77e0 into NixOS:master Sep 20, 2020
@mweinelt mweinelt deleted the python/junos_eznc branch September 20, 2020 13:28
@mweinelt mweinelt mentioned this pull request Sep 20, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @risicle @jonringer