Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

truvari: fix build #98250

Merged
merged 1 commit into from Sep 20, 2020
Merged

truvari: fix build #98250

merged 1 commit into from Sep 20, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Sep 19, 2020 •
edited

Motivation for this change

ZHF: #97479

Be less strict about versions. I'd feel better about this if there were proper runnable tests for this. But if they're just advocating regular users to install through pip install truvari, they're likely to get far more unreliable results.

I did start out bumping this to its latest version, 2.0.2, but after adding packages for 3 new dependencies I realized I would have ended up maintaining these packages I know nothing about and may have no users. 馃し (Edit: I went and finished this off under #98283, not sure which of these we want to use now)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
truvari: fix build
6c589e3 
be less strict about versions
@risicle risicle mentioned this pull request Sep 19, 2020
Merged
10 tasks
@AndersonTorres AndersonTorres changed the title truvari: fix build [ZHF 20.09] truvari: fix build Sep 19, 2020
@jonringer jonringer changed the title [ZHF 20.09] truvari: fix build truvari: fix build Sep 20, 2020
jonringer
jonringer approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98250 1

1 package built:
  • truvari

@jonringer jonringer merged commit 4637721 into NixOS:master Sep 20, 2020
@jonringer
Copy link
Contributor

@AndersonTorres usually prefixing the PR with [20.09] is meant for PRs that target the release branch, for targeting the master branch, this is fine :)

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 20, 2020
@risicle risicle mentioned this pull request Sep 23, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @jonringer