Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] topydo: Don't fail build on tests #98241

Merged
merged 1 commit into from Sep 22, 2020
Merged

[20.09] topydo: Don't fail build on tests #98241

merged 1 commit into from Sep 22, 2020

Conversation

Pamplemousse
Copy link
Member

@Pamplemousse Pamplemousse commented Sep 18, 2020 •
edited

Motivation for this change

(cherry picked from commit 9d30512)

backport of #98110

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Sep 19, 2020

Again, we need the backport information on the actual commit message

@jonringer
Copy link
Contributor

When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.

Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

@Pamplemousse
topydo: Don't fail build on tests
0fc6cda 
Signed-off-by: Pamplemousse <xav.maso@gmail.com>
(cherry picked from commit c603f62)
jonringer
jonringer approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98241 1

1 package built:
  • topydo

@jonringer jonringer merged commit 8e0373f into NixOS:release-20.09 Sep 22, 2020
@Pamplemousse Pamplemousse deleted the backport_topydo branch August 11, 2021 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@risicle risicle Awaiting requested review from risicle

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pamplemousse @risicle @jonringer