Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnat: fix build #98274

Merged
merged 1 commit into from Sep 20, 2020
Merged

gnat: fix build #98274

merged 1 commit into from Sep 20, 2020

Conversation

Lucus16
Copy link
Contributor

@Lucus16 Lucus16 commented Sep 19, 2020 •
edited

Motivation for this change

Tested gnat6, gnat9 compiled with gnat6, ghdl compiled with gnat9.

Fixes #97733

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Sep 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98274 1

6 packages built:
  • ghdl (ghdl-mcode)
  • ghdl-llvm
  • gnat (gnat9)
  • gnat10
  • gnat6
  • gnatboot

@jonringer jonringer merged commit 7ea5b08 into NixOS:master Sep 20, 2020
@omasanori
Copy link
Contributor

Thanks a lot!

@risicle
Copy link
Contributor

risicle commented Sep 20, 2020

Bit late now, but WFM non-nixos linux x86_64. Should probably get a faster machine sometime.

@jonringer
Copy link
Contributor

@risicle xD

@jonringer
Copy link
Contributor

Yea, i always wanted a server, so I got a 3990X. Thing is a beast for reviewing. Also finally allows for me to do reviews on pytorch and tensorflow without having my computer buckle under the memory and compute usage

@kquick kquick mentioned this pull request Sep 21, 2020
Closed
10 tasks
@Lucus16 Lucus16 mentioned this pull request Sep 23, 2020
Merged
10 tasks
@kquick kquick mentioned this pull request Sep 28, 2020
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
4 participants
@Lucus16 @omasanori @risicle @jonringer