Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.{segments,clldutils,csvw}: init #98297

Merged
merged 3 commits into from Sep 22, 2020
Merged

python3Packages.{segments,clldutils,csvw}: init #98297

merged 3 commits into from Sep 22, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Sep 19, 2020 •
edited

Motivation for this change

Part of our (@Mic92 and my) plan to package Mozilla TTS.

Phonemizer (up next) requires segments, which in turn requires clldutils and csvw.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt changed the title pythonPackages.{segments,clldutils,csvw}: init python3Packages.{segments,clldutils,csvw}: init Sep 19, 2020
@mweinelt
Copy link
Member Author

Result of nixpkgs-review pr 98297 1

6 packages built:
  • python37Packages.clldutils
  • python37Packages.csvw
  • python37Packages.segments
  • python38Packages.clldutils
  • python38Packages.csvw
  • python38Packages.segments

@mweinelt mweinelt force-pushed the python/segments,clldutils,csvw branch from ace2590 to f431b89 Compare September 19, 2020 21:36
@Mic92
Copy link
Member

Mic92 commented Sep 22, 2020

Result of nixpkgs-review pr 98297 1

6 packages failed to build:
  • python37Packages.clldutils
  • python37Packages.csvw
  • python37Packages.segments
  • python38Packages.clldutils
  • python38Packages.csvw
  • python38Packages.segments

@Mic92
Copy link
Member

Mic92 commented Sep 22, 2020

One of the checksums seems wrong:

hash mismatch in fixed-output derivation '/nix/store/z6sjq2icxw2rf0g2iw34q5qkzyi4qdr9-source':
  wanted: sha256-qeKjcW6SK0c5bmhXuUEHm/62h8UbD0TFiKbBPhVL0Cg=
  got:    sha256-rfnWempSe0V+V7g9tCN640nzEPaYwyPMmzDFtKPOXVU=

jonringer
jonringer reviewed Sep 22, 2020
View reviewed changes
pkgs/development/python-modules/csvw/default.nix Outdated
owner = "cldf";
repo = "csvw";
rev = "v${version}";
sha256 = "0a6h9cakxhd6i32l83qvqn3vdzlv0x0vjmv8dqwlfawjdrqs7qm9";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha256 = "0a6h9cakxhd6i32l83qvqn3vdzlv0x0vjmv8dqwlfawjdrqs7qm9";
sha256 = "0maxrsiv9i9hkg627hwqyq8g6jg3g8iv8gdqaxz4aysjd9xddydd"; 
hash mismatch in fixed-output derivation '/nix/store/z6sjq2icxw2rf0g2iw34q5qkzyi4qdr9-source':
  wanted: sha256:0a6h9cakxhd6i32l83qvqn3vdzlv0x0vjmv8dqwlfawjdrqs7qm9
  got:    sha256:0maxrsiv9i9hkg627hwqyq8g6jg3g8iv8gdqaxz4aysjd9xddydd

@mweinelt mweinelt force-pushed the python/segments,clldutils,csvw branch from f431b89 to fa91c09 Compare September 22, 2020 12:40
@mweinelt
Copy link
Member Author

Hah, odd. Wonder how I messed that up.

@mweinelt
Copy link
Member Author

Result of nixpkgs-review pr 98297 1

6 packages built:
  • python37Packages.clldutils
  • python37Packages.csvw
  • python37Packages.segments
  • python38Packages.clldutils
  • python38Packages.csvw
  • python38Packages.segments

@jonringer
Copy link
Contributor

Hah, odd. Wonder how I messed that up.

when I copy from other expressions, I sometimes forget about fixed-point derivation hashes as well

jonringer
jonringer approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 98297 1

6 packages failed to build:
  • python37Packages.clldutils
  • python37Packages.csvw
  • python37Packages.segments
  • python38Packages.clldutils
  • python38Packages.csvw
  • python38Packages.segments

@jonringer jonringer merged commit 0f50990 into NixOS:master Sep 22, 2020
@mweinelt mweinelt deleted the python/segments,clldutils,csvw branch September 22, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @Mic92 @jonringer